Updated config to handle null values

This commit is contained in:
Ytbarek Hailu
2025-08-11 12:58:19 -07:00
parent 02cfe28b70
commit 1d0ae6febc
3 changed files with 7 additions and 10 deletions

View File

@@ -1,6 +1,6 @@
version: 1
configTables:
continueOnFailure: true
continueOnFailure: false
scriptExclusion:
- ${EXAMPLE_DB}.${AUDIT_SCHEMA}.AUDIT_SEQ
dependencyOverride:

View File

@@ -22,20 +22,15 @@ public class ChangeManager {
private ScriptRepo scriptRepo;
private DependencyGraph dependencyGraph;
private ParameterInjector parameterInjector;
private boolean continueOnFailure = false;
public ChangeManager(Config config, ScriptSource scriptSource, ScriptRepo scriptRepo, DependencyGraph dependencyGraph, ParameterInjector parameterInjector) {
this.config= config;
this.continueOnFailure = config.isContinueOnFailure();
this.scriptSource = scriptSource;
this.scriptRepo = scriptRepo;
this.dependencyGraph = dependencyGraph;
this.parameterInjector = parameterInjector;
}
public void setContinueOnFailure(boolean continueOnFailure) {
this.continueOnFailure = continueOnFailure;
}
private void validateScript(Script script) {
if(script instanceof MigrationScript && scriptRepo.isScriptVersionDeployed(script)) {
log.error("Migration type script changed. Script for the object {} has changed from previous deployments.", script.getId());
@@ -67,12 +62,13 @@ public class ChangeManager {
parameterInjector.injectParameters(script);
validateScript(script);
scriptRepo.createScriptObject(script, onlyHashes);
} catch (Exception e) {
}
catch (Exception e) {
failedCount++;
failedScripts.add(script.getId());
log.error("Failed to deploy script {}: {}", script.getId(), e.getMessage());
if (!continueOnFailure) {
if (!config.isContinueOnFailure()) {
// throw the error as normal
throw e;
}
@@ -85,7 +81,8 @@ public class ChangeManager {
log.error("Failed scripts: {}", String.join(", ", failedScripts));
endSyncError(ChangeType.DEPLOY, errorMsg);
throw new RuntimeException(errorMsg);
} else {
}
else {
endSyncSuccess(ChangeType.DEPLOY, (long)sequencedScript.size());
}
}

View File

@@ -23,6 +23,6 @@ public class Config {
public boolean isContinueOnFailure() {
return continueOnFailure;
return continueOnFailure != null && continueOnFailure;
}
}