repo-mirrors/dbt-snowflake
1
0
Fork 0
mirror of https://github.com/dbt-labs/dbt-snowflake synced 2025-12-17 19:31:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Drop support for Python 3.8 (#1211)

Browse Source 
* drop support for python 3.8
This commit is contained in:
Mike Alfare
2024-10-17 15:48:05 -04:00
committed by GitHub
parent 8825ccb8bf
commit 78f86674bc
11 changed files with 53 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.changes/unreleased/Breaking Changes-20241016-183143.yaml Normal file
View File

@@ -0,0 +1,6 @@
kind: Breaking Changes
body: Drop support for Python 3.8
time: 2024-10-16T18:31:43.4167-04:00
custom:
Author: mikealfare
Issue: "1211"

4
.github/scripts/integration-test-matrix.js vendored
View File

@@ -1,6 +1,6 @@
module.exports = ({ context }) => {
const defaultPythonVersion = "3.8";
const supportedPythonVersions = ["3.8", "3.9", "3.10", "3.11", "3.12"];
const defaultPythonVersion = "3.9";
const supportedPythonVersions = ["3.9", "3.10", "3.11", "3.12"];
const supportedAdapters = ["snowflake"];
// if PR, generate matrix based on files changed and PR labels

8
.github/workflows/main.yml vendored
View File

@@ -50,7 +50,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.8'
python-version: '3.9'
- name: Install python dependencies
run: |
@@ -71,7 +71,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
python-version: ['3.9', '3.10', '3.11', '3.12']
env:
TOXENV: "unit"
@@ -127,7 +127,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.8'
python-version: '3.9'
- name: Install python dependencies
run: |
@@ -175,7 +175,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-12, windows-latest]
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
python-version: ['3.9', '3.10', '3.11', '3.12']
dist-type: ['whl', 'gz']
steps:

1
.pre-commit-config.yaml
View File

@@ -24,7 +24,6 @@ repos:
- id: black
args:
- --line-length=99
- --target-version=py38
- --target-version=py39
- --target-version=py310
- --target-version=py311

2
CONTRIBUTING.md
View File

@@ -79,7 +79,7 @@ WARNING: The parameters in your `test.env` file must link to a valid Snowflake a
There are a few methods for running tests locally.
#### `tox`
`tox` automatically runs unit tests against several Python versions using its own virtualenvs. Run `tox -p` to run unit tests for Python 3.8, Python 3.9, Python 3.10, and `flake8` in parallel. Run `tox -e py38` to invoke tests on Python version 3.8 only (use py38, py39, or py310). Tox recipes are found in `tox.ini`.
`tox` automatically runs unit tests against several Python versions using its own virtualenvs. Run `tox -p` to run unit tests for Python 3.9 and Python 3.10, and `flake8` in parallel. Run `tox -e py39` to invoke tests on Python version 3.9 only (use py39 or py310). Tox recipes are found in `tox.ini`.
#### `pytest`
You may run a specific test or group of tests using `pytest` directly. Activate a Python virtualenv active with dev dependencies installed. Then, run tests like so:

10
Makefile
View File

@@ -12,20 +12,20 @@ dev-uninstall: ## Uninstalls all packages while maintaining the virtual environm
pip uninstall -y dbt-snowflake
.PHONY: unit
unit: ## Runs unit tests with py38.
unit: ## Runs unit tests with py39.
@\
tox -e py38
tox -e py39
.PHONY: test
test: ## Runs unit tests with py38 and code checks against staged changes.
test: ## Runs unit tests with py39 and code checks against staged changes.
@\
tox -p -e py38; \
tox -p -e py39; \
pre-commit run --all-files
.PHONY: integration
integration: ## Runs snowflake integration tests with py38.
@\
tox -e py38-snowflake --
tox -e py39-snowflake --
.PHONY: clean
@echo "cleaning repo"

3
dev-requirements.txt
View File

@@ -6,8 +6,7 @@ git+https://github.com/dbt-labs/dbt-common.git
# dev
ipdb~=0.13.13
pre-commit~=3.7.0;python_version>="3.9"
pre-commit~=3.5.0;python_version<"3.9"
pre-commit~=3.7.0
# test
ddtrace==2.3.0

4
docker/Dockerfile
View File

@@ -1,7 +1,7 @@
# this image gets published to GHCR for production use
ARG py_version=3.11.2
FROM python:$py_version-slim-bullseye as base
FROM python:$py_version-slim-bullseye AS base
RUN apt-get update \
&& apt-get dist-upgrade -y \
@@ -25,7 +25,7 @@ ENV LANG=C.UTF-8
RUN python -m pip install --upgrade "pip==24.0" "setuptools==69.2.0" "wheel==0.43.0" --no-cache-dir
FROM base as dbt-snowflake
FROM base AS dbt-snowflake
ARG commit_ref=main

52
docker/dev.Dockerfile
View File

@@ -1,43 +1,43 @@
# this image does not get published, it is intended for local development only, see `Makefile` for usage
FROM ubuntu:22.04 as base
FROM ubuntu:24.04 AS base
# prevent python installation from asking for time zone region
ARG DEBIAN_FRONTEND=noninteractive
# add python repository
RUN apt-get update \
&& apt-get install -y software-properties-common=0.99.22.9 \
&& add-apt-repository -y ppa:deadsnakes/ppa \
&& apt-get clean \
&& rm -rf \
/var/lib/apt/lists/* \
/tmp/* \
/var/tmp/*
&& apt-get install -y software-properties-common=0.99.48 \
&& add-apt-repository -y ppa:deadsnakes/ppa \
&& apt-get clean \
&& rm -rf \
/var/lib/apt/lists/* \
/tmp/* \
/var/tmp/*
# install python
RUN apt-get update \
&& apt-get install -y --no-install-recommends \
build-essential=12.9ubuntu3 \
git-all=1:2.34.1-1ubuntu1.10 \
python3.8=3.8.19-1+jammy1 \
python3.8-dev=3.8.19-1+jammy1 \
python3.8-distutils=3.8.19-1+jammy1 \
python3.8-venv=3.8.19-1+jammy1 \
python3-pip=22.0.2+dfsg-1ubuntu0.4 \
python3-wheel=0.37.1-2ubuntu0.22.04.1 \
&& apt-get clean \
&& rm -rf \
/var/lib/apt/lists/* \
/tmp/* \
/var/tmp/*
&& apt-get install -y --no-install-recommends \
build-essential=12.10ubuntu1 \
git-all=1:2.43.0-1ubuntu7.1 \
python3.9=3.9.20-1+noble1 \
python3.9-dev=3.9.20-1+noble1 \
python3.9-distutils=3.9.20-1+noble1 \
python3.9-venv=3.9.20-1+noble1 \
python3-pip=24.0+dfsg-1ubuntu1 \
python3-wheel=0.42.0-2 \
&& apt-get clean \
&& rm -rf \
/var/lib/apt/lists/* \
/tmp/* \
/var/tmp/* \
# update the default system interpreter to the newly installed version
RUN update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.8 1
RUN update-alternatives --install /usr/bin/python python /usr/bin/python3.9 1
FROM base as dbt-snowflake-dev
FROM base AS dbt-snowflake-dev
HEALTHCHECK CMD python3 --version || exit 1
HEALTHCHECK CMD python --version || exit 1
# send stdout/stderr to terminal
ENV PYTHONUNBUFFERED=1
@@ -47,4 +47,4 @@ WORKDIR /opt/code
VOLUME /opt/code
# create a virtual environment
RUN python3 -m venv /opt/venv
RUN python -m venv /opt/venv

8
setup.py
View File

@@ -5,9 +5,9 @@ from pathlib import Path
import sys
# require python 3.8 or newer
if sys.version_info < (3, 8):
if sys.version_info < (3, 9):
print("Error: dbt does not support this version of Python.")
print("Please upgrade to Python 3.8 or higher.")
print("Please upgrade to Python 3.9 or higher.")
sys.exit(1)
@@ -72,12 +72,10 @@ setup(
"Operating System :: Microsoft :: Windows",
"Operating System :: MacOS :: MacOS X",
"Operating System :: POSIX :: Linux",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
],
python_requires=">=3.8",
python_requires=">=3.9",
)

6
tox.ini
View File

@@ -1,8 +1,8 @@
[tox]
skipsdist = True
envlist = py38,py39,py310,py311,py312
envlist = py39,py310,py311,py312
[testenv:{unit,py38,py39,py310,py311,py312,py}]
[testenv:{unit,py39,py310,py311,py312,py}]
description = unit testing
skip_install = true
passenv =
@@ -13,7 +13,7 @@ deps =
-rdev-requirements.txt
-e.
[testenv:{integration,py38,py39,py310,py311,py312,py}-{snowflake}]
[testenv:{integration,py39,py310,py311,py312,py}-{snowflake}]
description = adapter plugin integration testing
skip_install = true
passenv =