repo-mirrors/dbt-project-evaluator
1
0
Fork 0
mirror of https://github.com/dbt-labs/dbt-project-evaluator.git synced 2025-12-18 02:11:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

make sure we catch single character dbs and schemas

Browse Source
This commit is contained in:
Dave Connors
2024-10-25 10:19:58 -05:00
parent 77384c6ce5
commit bee93938db
3 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
integration_tests/models/marts/fct_model_6.sql
View File

@@ -92,6 +92,13 @@ select 1 as id
select
5 as id
from {{ var('my_table_reference', 'table_d') }}
union all
select
5 as id
from a.b.c
union all
select
5 as id
from a.b
#}

2
integration_tests/seeds/dag/test_fct_hard_coded_references.csv
View File

@@ -1,2 +1,2 @@
model,hard_coded_references
fct_model_6,"""my_db"".""my_schema"".""my_table"", ""my_schema"".""raw_relation_5"", ""raw_relation_2"", 'my_db'.'my_schema'.'my_table', 'my_schema'.'raw_relation_5', 'raw_relation_4', [my_db].[my_schema].[my_table], [my_schema].[raw_relation_5], [raw_relation_3], `my_db`.`my_schema`.`my_table`, `my_schema`.`raw_relation_5`, `project-name.dataset_name.table_name`, `raw_relation_1`, my_db.my_schema.my_table, my_schema.raw_relation_5, {{ var(""my_table_reference"") }}, {{ var(""my_table_reference"", ""table_d"") }}, {{ var('my_table_reference') }}, {{ var('my_table_reference', 'table_d') }}"
fct_model_6,"""my_db"".""my_schema"".""my_table"", ""my_schema"".""raw_relation_5"", ""raw_relation_2"", 'my_db'.'my_schema'.'my_table', 'my_schema'.'raw_relation_5', 'raw_relation_4', [my_db].[my_schema].[my_table], [my_schema].[raw_relation_5], [raw_relation_3], `my_db`.`my_schema`.`my_table`, `my_schema`.`raw_relation_5`, `project-name.dataset_name.table_name`, `raw_relation_1`, a.b, a.b.c, my_db.my_schema.my_table, my_schema.raw_relation_5, {{ var(""my_table_reference"") }}, {{ var(""my_table_reference"", ""table_d"") }}, {{ var('my_table_reference') }}, {{ var('my_table_reference', 'table_d') }}"
1 model hard_coded_references
2 fct_model_6 "my_db"."my_schema"."my_table", "my_schema"."raw_relation_5", "raw_relation_2", 'my_db'.'my_schema'.'my_table', 'my_schema'.'raw_relation_5', 'raw_relation_4', [my_db].[my_schema].[my_table], [my_schema].[raw_relation_5], [raw_relation_3], `my_db`.`my_schema`.`my_table`, `my_schema`.`raw_relation_5`, `project-name.dataset_name.table_name`, `raw_relation_1`, my_db.my_schema.my_table, my_schema.raw_relation_5, {{ var("my_table_reference") }}, {{ var("my_table_reference", "table_d") }}, {{ var('my_table_reference') }}, {{ var('my_table_reference', 'table_d') }} "my_db"."my_schema"."my_table", "my_schema"."raw_relation_5", "raw_relation_2", 'my_db'.'my_schema'.'my_table', 'my_schema'.'raw_relation_5', 'raw_relation_4', [my_db].[my_schema].[my_table], [my_schema].[raw_relation_5], [raw_relation_3], `my_db`.`my_schema`.`my_table`, `my_schema`.`raw_relation_5`, `project-name.dataset_name.table_name`, `raw_relation_1`, a.b, a.b.c, my_db.my_schema.my_table, my_schema.raw_relation_5, {{ var("my_table_reference") }}, {{ var("my_table_reference", "table_d") }}, {{ var('my_table_reference') }}, {{ var('my_table_reference', 'table_d') }}

10
macros/find_all_hard_coded_references.sql
View File

@@ -134,7 +134,7 @@
# third matching group
# at least 1 word character
(\w+-?\w+)
(\w+-?\w*)
# fouth matching group
# 1 or 0 of (closing bracket, backtick, or quotation mark)
@@ -150,7 +150,7 @@
# seventh matching group
# at least 1 word character
(\w+-?\w+)
(\w+-?\w*)
# eighth matching group
# 1 or 0 of (closing bracket, backtick, or quotation mark) folowed by a whitespace character or end of string
@@ -173,7 +173,7 @@
# third matching group
# at least 1 word character
(\w+-?\w+)
(\w+-?\w*)
# fouth matching group
# 1 or 0 of (closing bracket, backtick, or quotation mark)
@@ -189,7 +189,7 @@
# seventh matching group
# at least 1 word character
(\w+-?\w+)
(\w+-?\w*)
# eighth matching group
# 1 or 0 of (closing bracket, backtick, or quotation mark)
@@ -205,7 +205,7 @@
# eleventh matching group
# at least 1 word character
(\w+-?\w+)
(\w+-?\w*)
# twelfth matching group
# 1 or 0 of (closing bracket, backtick, or quotation mark) followed by a whitespace character or end of string