repo-mirrors/dbt-core
1
0
Fork 1
mirror of https://github.com/dbt-labs/dbt-core synced 2025-12-17 19:31:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

adding clean_up methods to basic and unique_id tests (#9195)

Browse Source 
* init attempt of adding clean_up methods to basic and unique_id tests

* swapping cleanup method drop of test_schema to unique_schema to test breakage on docs_generate test

* moving the clean_up method down into class BaseDocsGenerate

* remove drop relation for unique_schema

* manually define alternate_schema for clean_up as not being seen as part of project_config

* add changelog

* remove unneeded changelog

* uncomment line that generates new manifest and delete manifest our changes created

* make sure the manifest test is deleted and readd older version of manifest.json to appease test

* manually revert file to previous commit

* Revert "manually revert file to previous commit"

This reverts commit a755419e8b.
This commit is contained in:
Matthew McKnight
2023-12-12 13:09:33 -06:00
committed by GitHub
parent 6e0a387205
commit c2bc2f009b
12 changed files with 113 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/adapter/dbt/tests/adapter/basic/test_adapter_methods.py
View File

@@ -90,6 +90,17 @@ class BaseAdapterMethod:
"name": "adapter_methods",
}
@pytest.fixture(autouse=True)
def clean_up(self, project):
yield
with project.adapter.connection_named("__test"):
relation = project.adapter.Relation.create(
database=project.database, schema=project.test_schema
)
project.adapter.drop_schema(relation)
pass
# snowflake need all tables in CAP name
@pytest.fixture(scope="class")
def equal_tables(self):

11
tests/adapter/dbt/tests/adapter/basic/test_base.py
View File

@@ -37,6 +37,17 @@ class BaseSimpleMaterializations:
"name": "base",
}
@pytest.fixture(autouse=True)
def clean_up(self, project):
yield
with project.adapter.connection_named("__test"):
relation = project.adapter.Relation.create(
database=project.database, schema=project.test_schema
)
project.adapter.drop_schema(relation)
pass
def test_base(self, project):
# seed command

12
tests/adapter/dbt/tests/adapter/basic/test_docs_generate.py
View File

@@ -428,6 +428,18 @@ class BaseDocsGenerate(BaseGenerateProject):
model_stats=no_stats(),
)
@pytest.fixture(autouse=True)
def clean_up(self, project):
yield
with project.adapter.connection_named("__test"):
alternate_schema = f"{project.test_schema}_test"
relation = project.adapter.Relation.create(
database=project.database, schema=alternate_schema
)
project.adapter.drop_schema(relation)
pass
# Test "--no-compile" flag works and produces no manifest.json
def test_run_and_generate_no_compile(self, project, expected_catalog):
start_time = run_and_generate(project, ["--no-compile"])

11
tests/adapter/dbt/tests/adapter/basic/test_generic_tests.py
View File

@@ -33,6 +33,17 @@ class BaseGenericTests:
"schema_table.yml": generic_test_table_yml,
}
@pytest.fixture(autouse=True)
def clean_up(self, project):
yield
with project.adapter.connection_named("__test"):
relation = project.adapter.Relation.create(
database=project.database, schema=project.test_schema
)
project.adapter.drop_schema(relation)
pass
def test_generic_tests(self, project):
# seed command
results = run_dbt(["seed"])

11
tests/adapter/dbt/tests/adapter/basic/test_incremental.py
View File

@@ -23,6 +23,17 @@ class BaseIncremental:
def seeds(self):
return {"base.csv": seeds_base_csv, "added.csv": seeds_added_csv}
@pytest.fixture(autouse=True)
def clean_up(self, project):
yield
with project.adapter.connection_named("__test"):
relation = project.adapter.Relation.create(
database=project.database, schema=project.test_schema
)
project.adapter.drop_schema(relation)
pass
def test_incremental(self, project):
# seed command
results = run_dbt(["seed"])

11
tests/adapter/dbt/tests/adapter/basic/test_singular_tests.py
View File

@@ -18,6 +18,17 @@ class BaseSingularTests:
def project_config_update(self):
return {"name": "singular_tests"}
@pytest.fixture(autouse=True)
def clean_up(self, project):
yield
with project.adapter.connection_named("__test"):
relation = project.adapter.Relation.create(
database=project.database, schema=project.test_schema
)
project.adapter.drop_schema(relation)
pass
def test_singular_tests(self, project):
# test command
results = run_dbt(["test"], expect_pass=False)

11
tests/adapter/dbt/tests/adapter/basic/test_singular_tests_ephemeral.py
View File

@@ -39,6 +39,17 @@ class BaseSingularTestsEphemeral:
"name": "singular_tests_ephemeral",
}
@pytest.fixture(autouse=True)
def clean_up(self, project):
yield
with project.adapter.connection_named("__test"):
relation = project.adapter.Relation.create(
database=project.database, schema=project.test_schema
)
project.adapter.drop_schema(relation)
pass
def test_singular_tests_ephemeral(self, project):
# check results from seed command
results = run_dbt(["seed"])

11
tests/adapter/dbt/tests/adapter/basic/test_snapshot_check_cols.py
View File

@@ -35,6 +35,17 @@ class BaseSnapshotCheckCols:
"cc_name_snapshot.sql": cc_name_snapshot_sql,
}
@pytest.fixture(autouse=True)
def clean_up(self, project):
yield
with project.adapter.connection_named("__test"):
relation = project.adapter.Relation.create(
database=project.database, schema=project.test_schema
)
project.adapter.drop_schema(relation)
pass
def test_snapshot_check_cols(self, project):
# seed command
results = run_dbt(["seed"])

11
tests/adapter/dbt/tests/adapter/basic/test_snapshot_timestamp.py
View File

@@ -33,6 +33,17 @@ class BaseSnapshotTimestamp:
def project_config_update(self):
return {"name": "snapshot_strategy_timestamp"}
@pytest.fixture(autouse=True)
def clean_up(self, project):
yield
with project.adapter.connection_named("__test"):
relation = project.adapter.Relation.create(
database=project.database, schema=project.test_schema
)
project.adapter.drop_schema(relation)
pass
def test_snapshot_timestamp(self, project):
# seed command
results = run_dbt(["seed"])

11
tests/adapter/dbt/tests/adapter/incremental/test_incremental_unique_id.py
View File

@@ -344,6 +344,17 @@ class BaseIncrementalUniqueKey:
"add_new_rows.sql": seeds__add_new_rows_sql,
}
@pytest.fixture(autouse=True)
def clean_up(self, project):
yield
with project.adapter.connection_named("__test"):
relation = project.adapter.Relation.create(
database=project.database, schema=project.test_schema
)
project.adapter.drop_schema(relation)
pass
def update_incremental_model(self, incremental_model):
"""update incremental model after the seed table has been updated"""
model_result_set = run_dbt(["run", "--select", incremental_model])

2
tests/functional/artifacts/data/state/v12/manifest.json
View File

File diff suppressed because one or more lines are too long

2
tests/functional/artifacts/test_previous_version_state.py
View File

@@ -412,7 +412,7 @@ class TestPreviousVersionState:
current_manifest_schema_version == self.CURRENT_EXPECTED_MANIFEST_VERSION
), "Sounds like you've bumped the manifest version and need to update this test!"
# If we need a newly generated manifest, uncomment the following line and commit the result
self.generate_latest_manifest(project, current_manifest_schema_version)
# self.generate_latest_manifest(project, current_manifest_schema_version)
self.compare_previous_state(project, current_manifest_schema_version, True, 0)
def test_backwards_compatible_versions(self, project):